Skip to content

Add support for commonLabels in Service template#188

Merged
ChrisJBurns merged 5 commits intopact-foundation:masterfrom
paweligawel:add-common-label-to-service
Oct 26, 2025
Merged

Add support for commonLabels in Service template#188
ChrisJBurns merged 5 commits intopact-foundation:masterfrom
paweligawel:add-common-label-to-service

Conversation

@paweligawel
Copy link
Copy Markdown
Contributor

This PR enhances the Helm chart for Pact Broker by adding support for commonLabels in the templates/service.yaml manifest.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Oct 24, 2025
@ChrisJBurns
Copy link
Copy Markdown
Contributor

ChrisJBurns commented Oct 25, 2025

@paweligawel Would you be ok to bump the helm chart version per pipeline failures

EDIT
Ignore me, I think you just need to run the pre-commit command to sort the README out. The other pipeline failure is due to the removed postgres image. I need to fix this

@github-actions github-actions bot removed the stale label Oct 26, 2025
@paweligawel
Copy link
Copy Markdown
Contributor Author

@ChrisJBurns I have re-run the process to regenerate the README.md and this removed newline at the end of the file.

~/github/pact-broker-chart/ add-common-label-to-service ❯❯❯ pre-commit run --all-files 
Helm Docs................................................................Passed

@ChrisJBurns
Copy link
Copy Markdown
Contributor

@paweligawel I've sorted the pipeline out now which should mean things pass, however I had to bump the Chart versions again to 3.3.5, would you be able to do another bump to 3.3.6? We should be good to merge then

@ChrisJBurns ChrisJBurns merged commit 3c5137a into pact-foundation:master Oct 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants